Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove redundant move for build on noble #12

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Jul 1, 2024

Description

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wep21 LGTM, thanks

@wep21 wep21 force-pushed the fix-compiler-warning branch from d19c2f0 to 06103c9 Compare July 1, 2024 11:40
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 15.93%. Comparing base (08afed3) to head (d4429b6).
Report is 1 commits behind head on main.

Files Patch % Lines
autoware_lanelet2_extension/lib/utilities.cpp 0.00% 1 Missing ⚠️
...ware_lanelet2_extension/src/check_right_of_way.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   15.93%   15.93%           
=======================================
  Files          40       40           
  Lines        2748     2748           
  Branches     1339     1339           
=======================================
  Hits          438      438           
  Misses       2222     2222           
  Partials       88       88           
Flag Coverage Δ *Carryforward flag
differential 15.93% <0.00%> (ø)
total 15.95% <ø> (+0.01%) ⬆️ Carriedforward from 08afed3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
@wep21 wep21 force-pushed the fix-compiler-warning branch from 06103c9 to d4429b6 Compare July 2, 2024 05:42
@youtalk youtalk merged commit a2d5a6f into autowarefoundation:main Jul 2, 2024
16 of 18 checks passed
@wep21 wep21 deleted the fix-compiler-warning branch July 2, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants